Fix WP Photo Directory DAG#5038
Merged
Merged
Conversation
krysal
approved these changes
Oct 14, 2024
Member
krysal
left a comment
There was a problem hiding this comment.
Good catch, Sara! I modified the tests so the CI passes. Thank you!
I noticed in the notifications Slack channel that only the last two runs brought nothing. So this is relatively recent, but it raises the need to detect this kind of issue if it continues to happen with other DAGs.
8 tasks
Danil49
pushed a commit
to Danil49/openverse
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was trying this DAG locally and getting zero results every time. It turns out the
formatquery parameter breaks the response entirely:This is empty: https://wordpress.org/photos/wp-json/wp/v2/photos?format=json
Whereas this works fine and returns JSON every time: https://wordpress.org/photos/wp-json/wp/v2/photos
Removing the format query parameter from the DAG fixes the issue.
Testing Instructions
Run the DAG on
mainand confirm you get zero results inpull_image_data.Run the DAG on this branch, and confirm you now get the full result set.
Checklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin