Align PHP minimum version checks#202
Conversation
|
@10up/open-source-practice could use a quick code review on this for the 4.4.0 release, thanks! |
|
@jeffpaul @ravinderk Should we use https://github.com/10up/wp-compat-validation-tool instead of adding manual checks across all plugins? There is |
|
@faisal-alvi yes, probably worth updating to that newly available tool |
|
Fixed PR. It was made by a hot needle in Github web app. Sorry, I called incorrect PHP function. It should be |
|
@radeno can you use wp-compat-validation-tool library to validate the PHP version? Sample code: https://github.com/10up/maps-block-apple/pull/174/files |
|
@ravinderk from my point of view this is bigger change. My PR aligned two different PHP versions (7.4 and 8.0) checks currently implemented to just one (8.0). That's all. |
Description of the Change
After merging 3b7f2fa there was introduced helper method. Align PHP version checking
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: