Skip to content

Align PHP minimum version checks#202

Merged
jeffpaul merged 2 commits into
10up:developfrom
radeno:patch-1
Jan 2, 2024
Merged

Align PHP minimum version checks#202
jeffpaul merged 2 commits into
10up:developfrom
radeno:patch-1

Conversation

@radeno

@radeno radeno commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Description of the Change

After merging 3b7f2fa there was introduced helper method. Align PHP version checking

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@radeno radeno requested review from a team and rickalee as code owners October 10, 2023 11:30
@radeno radeno requested review from dkotter and removed request for a team October 10, 2023 11:30
@jeffpaul jeffpaul added this to the 4.4.0 milestone Oct 10, 2023
@jeffpaul jeffpaul requested a review from a team October 10, 2023 13:26
@jeffpaul

Copy link
Copy Markdown
Member

@10up/open-source-practice could use a quick code review on this for the 4.4.0 release, thanks!

Comment thread windows-azure-storage.php Outdated

@ravinderk ravinderk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radeno, I left a few suggestions. LEt me know if you have any questions.

@faisal-alvi

Copy link
Copy Markdown

@jeffpaul @ravinderk Should we use https://github.com/10up/wp-compat-validation-tool instead of adding manual checks across all plugins? There is set_php_min_required_version( 8.0 ) function that seems useful here.

@jeffpaul

Copy link
Copy Markdown
Member

@faisal-alvi yes, probably worth updating to that newly available tool

@dkotter dkotter modified the milestones: 4.4.0, 4.5.0 Oct 13, 2023
@radeno

radeno commented Oct 16, 2023

Copy link
Copy Markdown
Contributor Author

Fixed PR. It was made by a hot needle in Github web app. Sorry, I called incorrect PHP function. It should be was_site_meets_php_requirements. Now it is fixed
@ravinderk @faisal-alvi @jeffpaul

@faisal-alvi faisal-alvi requested a review from ravinderk October 17, 2023 13:46
@ravinderk

Copy link
Copy Markdown

@radeno can you use wp-compat-validation-tool library to validate the PHP version?

Sample code: https://github.com/10up/maps-block-apple/pull/174/files

cc: @jeffpaul @faisal-alvi

@radeno

radeno commented Oct 22, 2023

Copy link
Copy Markdown
Contributor Author

@ravinderk from my point of view this is bigger change. My PR aligned two different PHP versions (7.4 and 8.0) checks currently implemented to just one (8.0). That's all.
Implementing another dependency and removing current logic should not prevent deploying this module as soon as possible.

@jeffpaul jeffpaul merged commit 7e83188 into 10up:develop Jan 2, 2024
@radeno radeno deleted the patch-1 branch January 5, 2024 10:47
@dkotter dkotter modified the milestones: 4.5.0, 4.4.1 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants