Tuned CI/CD for FIPs build#218
Merged
Enmk merged 5 commits intoJan 17, 2023
Merged
Conversation
Enmk
reviewed
Jan 12, 2023
Enmk
reviewed
Jan 12, 2023
8c22555 to
b1d5419
Compare
0cee3a2 to
c588824
Compare
Collaborator
|
@zvonand, let's add a description to this PR :). |
Enmk
reviewed
Jan 14, 2023
Enmk
left a comment
Member
There was a problem hiding this comment.
Needs some clarifications and also maybe cleanup?
Enmk
reviewed
Jan 17, 2023
| # and on hung you can simply press Ctrl-C and it will spawn a python pdb, | ||
| # but on SIGINT dockerd will exit, so ignore it to preserve the daemon. | ||
| trap '' INT | ||
| dockerd --host=unix:///var/run/docker.sock --host=tcp://0.0.0.0:2375 --default-address-pool base=172.17.0.0/12,size=24 & |
Member
There was a problem hiding this comment.
Where do these values (172.17.0.0 and :2375) come from?
Member
Author
There was a problem hiding this comment.
2375 is a default port for docker.
this IP is semi-default IP pool for composing networks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables building via workflows of FIPS build (with BoringSSL)
Changes: