Skip to content

23.3 Backport of #52634 - init and destroy ares channel on demand.#295

Merged
Enmk merged 2 commits into
customizations/23.3.8from
backports/23.3.8/52634_init_and_destroy_ares_channel_on_demand
Aug 16, 2023
Merged

23.3 Backport of #52634 - init and destroy ares channel on demand.#295
Enmk merged 2 commits into
customizations/23.3.8from
backports/23.3.8/52634_init_and_destroy_ares_channel_on_demand

Conversation

@arthurpassos

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Backport: ClickHouse#52634

Remove mutex from CaresPTRResolver and create ares_channel on demand. Trying to fix: ClickHouse#52327 (comment)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@altinity-robot

altinity-robot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit 6acb6d4 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success

@Enmk Enmk changed the title init and destroy ares channel on demand.. 23.3 Backport of #52634 - init and destroy ares channel on demand. Aug 14, 2023

@Enmk Enmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit fe3d80a into customizations/23.3.8 Aug 16, 2023
@Enmk Enmk mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants