Skip to content

23.3 Backport of #58831- Fix logger leak#356

Merged
Enmk merged 2 commits into
customizations/23.3.19from
backports/23.3.19/58831_fix_logger_leak
Feb 20, 2024
Merged

23.3 Backport of #58831- Fix logger leak#356
Enmk merged 2 commits into
customizations/23.3.19from
backports/23.3.19/58831_fix_logger_leak

Conversation

@Enmk

@Enmk Enmk commented Jan 30, 2024

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed leaking loggers in some cases, like creating and dropping tables (ClickHouse#58831, ClickHouse#59273 by @kitaisreal)

@altinity-robot

altinity-robot commented Jan 30, 2024

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit a17386f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@Enmk

Enmk commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

Looks like we also have to backport ClickHouse#59273 due to ClickHouse#59254

@Enmk Enmk force-pushed the backports/23.3.19/58831_fix_logger_leak branch from 11beb55 to 31a07f1 Compare February 5, 2024 17:43
@Enmk Enmk force-pushed the backports/23.3.19/58831_fix_logger_leak branch from 31a07f1 to a17386f Compare February 9, 2024 00:19
@Enmk

Enmk commented Feb 20, 2024

Copy link
Copy Markdown
Member Author

Fix was confirmed manually

@Enmk Enmk merged commit 8fb6197 into customizations/23.3.19 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants