Skip to content

23.8 Backports of #56502 and #58638 - Fix projection analysis#391

Merged
Enmk merged 3 commits into
customizations/23.8.16from
backports/23.8/56502_fix_projection_analysis
Oct 17, 2024
Merged

23.8 Backports of #56502 and #58638 - Fix projection analysis#391
Enmk merged 3 commits into
customizations/23.8.16from
backports/23.8/56502_fix_projection_analysis

Conversation

@Enmk

@Enmk Enmk commented Apr 18, 2024

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Projection analysis now comes after partition pruning, resulting in better plan efficiency and better statistic log (ClickHouse#56502 by @amosbird)
Fix broken partition key analysis when doing projection optimization with force_index_by_date = 1 (ClickHouse#58638 by @amosbird)

@altinity-robot

altinity-robot commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit 875ab56 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@Enmk

Enmk commented Apr 24, 2024

Copy link
Copy Markdown
Member Author

Decided not to include in 23.8.11, since there are not enough tests and backports themselves are kind of risky.

@Enmk Enmk closed this Apr 24, 2024
@Enmk Enmk reopened this May 1, 2024
@Enmk Enmk changed the base branch from customizations/23.8.11 to customizations/23.8.16 October 17, 2024 16:51
alexey-milovidov and others added 2 commits October 17, 2024 18:51
Fix two cases of projection analysis.
Fix broken partition key analysis when doing projection optimization
@Enmk Enmk force-pushed the backports/23.8/56502_fix_projection_analysis branch from f72fe4e to eb5814e Compare October 17, 2024 16:51
Fixed .reference with accordance with the reference (24.3) version output
@Enmk Enmk merged commit b97c01c into customizations/23.8.16 Oct 17, 2024
@Enmk Enmk mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants