Skip to content

24.3 backport of #66237 - Fix detection of number of CPUs in containers#420

Merged
Enmk merged 1 commit into
customizations/24.3.5from
backports/24.3/66237_fix_cgroup_CPU_number_detection
Jul 15, 2024
Merged

24.3 backport of #66237 - Fix detection of number of CPUs in containers#420
Enmk merged 1 commit into
customizations/24.3.5from
backports/24.3/66237_fix_cgroup_CPU_number_detection

Conversation

@Enmk

@Enmk Enmk commented Jul 11, 2024

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix detection of number of CPUs in containers. In the case when the 'root' cgroup was used (i.e. name of cgroup was empty, which is common for containers) ClickHouse was ignoring the CPU limits set for the container. (ClickHouse#66237 by @filimonov)

@altinity-robot

altinity-robot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit eb38350 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success

In the case when the 'parent' cgroup was used (i.e. name of cgroup was empty, which is common for containers)
ClickHouse was ignoring the CPU limits set for the container.
@Enmk Enmk force-pushed the backports/24.3/66237_fix_cgroup_CPU_number_detection branch from fe373e9 to eb38350 Compare July 12, 2024 19:11
@Enmk Enmk merged commit 8a11d74 into customizations/24.3.5 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants