Skip to content

23.8 Backport of #67748 Fix expiration in RoleCache#451

Merged
Enmk merged 3 commits into
customizations/23.8.16from
backports/23.8/67748_fix_expiration_in_rolecache
Sep 12, 2024
Merged

23.8 Backport of #67748 Fix expiration in RoleCache#451
Enmk merged 3 commits into
customizations/23.8.16from
backports/23.8/67748_fix_expiration_in_rolecache

Conversation

@ilejn

@ilejn ilejn commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix expiration in RoleCache.

RoleCache is a cache containing information about roles and access rights extracted from roles. Sometimes it could work incorrectly after a role in the cache expired and then got changed by admin granting or revoking something. This PR fixes that problem.

The problem in the code which this PR is fixing was found by @ilejn in ClickHouse#66845

(ClickHouse#67748 by vitibar)

@altinity-robot

altinity-robot commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit 8b42292 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Docker image for serversThe check to build and optionally push the mentioned image to docker hub❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@Enmk Enmk changed the title Backport of #67748 Fix expiration in RoleCache 23.8 Backport of #67748 Fix expiration in RoleCache Aug 30, 2024
@Enmk Enmk force-pushed the backports/23.8/67748_fix_expiration_in_rolecache branch from 4724ca2 to 8b42292 Compare September 12, 2024 05:56

@Enmk Enmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit c9504c5 into customizations/23.8.16 Sep 12, 2024
@Enmk Enmk mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants