Skip to content

24.3 Backport of PR #67654: Fix serialization of parameterized view parameters#502

Merged
Enmk merged 1 commit into
customizations/24.3.11from
backports/24.3.11/67654_serialization_of_parameterized_view_parameters
Oct 16, 2024
Merged

24.3 Backport of PR #67654: Fix serialization of parameterized view parameters#502
Enmk merged 1 commit into
customizations/24.3.11from
backports/24.3.11/67654_serialization_of_parameterized_view_parameters

Conversation

@shiyer7474

Copy link
Copy Markdown

Backport of ClickHouse#67654.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes ClickHouse#62282. Removed the call to convertFieldToString() and added datatype specific serialization code. Parameterized view substitution was broken for multiple datatypes when parameter value was a function or expression returning datatype instance.

…w_serialization_fix

Fix serialization of parameterized view parameters
@altinity-robot

altinity-robot commented Oct 14, 2024

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit f30f071 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process⏳ pending
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success

@shiyer7474

Copy link
Copy Markdown
Author

Integration test suite failures are still "test_distributed_inter_server_secret". Other stateless test failures are same as in other PRs.

There is a "Docker keeper image" build error that looks interesting, I will try a rerun.

@shiyer7474

Copy link
Copy Markdown
Author

@Enmk Enmk merged commit f424b1a into customizations/24.3.11 Oct 16, 2024
@shiyer7474 shiyer7474 deleted the backports/24.3.11/67654_serialization_of_parameterized_view_parameters branch October 17, 2024 02:59
@Enmk Enmk mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants