Skip to content

23.8 Snapshot runners and scheduled runs#506

Merged
Enmk merged 9 commits into
customizations/23.8.16from
23.8.16-scheduled-runs
Oct 21, 2024
Merged

23.8 Snapshot runners and scheduled runs#506
Enmk merged 9 commits into
customizations/23.8.16from
23.8.16-scheduled-runs

Conversation

@MyroTk

@MyroTk MyroTk commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Switch to snapshot runners to improve stability.
  • Add support for scheduled runs.

@altinity-robot

altinity-robot commented Oct 18, 2024

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit 6006b47 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

# Rebuild all images on push or release
if pr_info.number == 0:
# Rebuild all images on push, release, or scheduled run
if pr_info.number in [0,1]:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a comment about those special values. Why 0 and why 1? The best would be to move those values out as a named constants, like (somewhere in pr_info.py maybe?):

# Since we do both release and scheduled runs on the branch (there is no PR),
# and PR number is an essential part of the CI/CD scripts,
# for simplicity and consistency throughout the codebase,
# we hardcore those runs corresponding pseudo PR numbers:
RELEASE_RUN_PR_ID=0
SCHEDULED_RUN_PR_ID=1

- name: Setup zram
shell: bash
run: |
sudo modprobe zram

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining the intention of this code block, something like:
to make sure some of the tests with heavy RAM usage actually pass, we allocate 2% of RAM as SWAP on a ZRAM.

@Enmk Enmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix mentioned issue in the next PRs. This one is Ok to merge

@Enmk Enmk merged commit a48e4ba into customizations/23.8.16 Oct 21, 2024
@Enmk Enmk mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants