23.8 Snapshot runners and scheduled runs#506
Merged
Merged
Conversation
Collaborator
|
This is an automated comment for commit 6006b47 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Enmk
reviewed
Oct 21, 2024
| # Rebuild all images on push or release | ||
| if pr_info.number == 0: | ||
| # Rebuild all images on push, release, or scheduled run | ||
| if pr_info.number in [0,1]: |
Member
There was a problem hiding this comment.
This requires a comment about those special values. Why 0 and why 1? The best would be to move those values out as a named constants, like (somewhere in pr_info.py maybe?):
# Since we do both release and scheduled runs on the branch (there is no PR),
# and PR number is an essential part of the CI/CD scripts,
# for simplicity and consistency throughout the codebase,
# we hardcore those runs corresponding pseudo PR numbers:
RELEASE_RUN_PR_ID=0
SCHEDULED_RUN_PR_ID=1
Enmk
reviewed
Oct 21, 2024
| - name: Setup zram | ||
| shell: bash | ||
| run: | | ||
| sudo modprobe zram |
Member
There was a problem hiding this comment.
Please add a comment explaining the intention of this code block, something like:
to make sure some of the tests with heavy RAM usage actually pass, we allocate 2% of RAM as SWAP on a ZRAM.
Enmk
approved these changes
Oct 21, 2024
Enmk
left a comment
Member
There was a problem hiding this comment.
LGTM, please fix mentioned issue in the next PRs. This one is Ok to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):