Fix missing ownerReferences in pvc metadata

[fkywong]

Problem

See issue #1799, #1843

Root Cause

By default, the Clickhouse Helm chart deploys the Keeper StatefulSet with PVCs provisioned by the Operator (chk.yaml:33), but the Operator does not set metadata.OwnerReferences on the PVCs.

Without metadata.OwnerReferences correctly set, ArgoCD can't attribute the PVCs to the application installation, and will incorrectly mark the PVCs as OutOfSync, which leads to the following undesirable behaviors/workarounds documented in the aforementioned issue.

The cluster instance's PVCs don't encounter the same issue because the Helm chart chi.yaml doesn't specify spec.defaults.storageManagement.provisioner, so the default StatefulSet provisioner is used:

clickhouse-operator/pkg/model/common/volume/volumer.go

Lines 60 to 61 in 732a1be

	// Default value
	return api.PVCProvisionerStatefulSet

Thus, ArgoCD is able to correctly map the StatefulSet-created PVCs to the CHI StatefulSet resources.

Solution: set metadata.OwnerReferences on PVCs

There's already precedence with doing this on Operator-provisioned StatefulSet and Service k8s resources:

clickhouse-operator/pkg/model/common/creator/stateful-set.go

Lines 35 to 41 in 732a1be

	ObjectMeta: meta.ObjectMeta{
	Name: c.nm.Name(interfaces.NameStatefulSet, host),
	Namespace: host.GetRuntime().GetAddress().GetNamespace(),
	Labels: c.macro.Scope(host).Map(c.tagger.Label(interfaces.LabelSTS, host)),
	Annotations: c.macro.Scope(host).Map(c.tagger.Annotate(interfaces.AnnotateSTS, host)),
	OwnerReferences: c.or.CreateOwnerReferences(c.cr),
	},

clickhouse-operator/pkg/model/common/creator/service.go

Lines 81 to 85 in 732a1be

	service.OwnerReferences = ownerReferences
	// Combine labels and annotations
	service.Labels = macro.Map(util.MergeStringMapsOverwrite(service.Labels, labels))
	service.Annotations = macro.Map(util.MergeStringMapsOverwrite(service.Annotations, annotations))

This PR makes code changes in a similar manner to the above code snippets.

Pull Request checklist

• All commits in the PR are squashed. More info
• The PR is made into dedicated next-release branch, not into master branch¹. More info
• The PR is signed. More info

[sunsingerus]

Crushes tests on PVC retain policy. Reverted ATM, will think what to do about it.

[augustodileo]

Was this delivered into any release? Im on 0.26.2 and not present the ownerReferences in there

[fkywong]

@augustodileo unfortunately due to compatibility issues with tests mentioned earlier, this PR was reverted by a4f5fe1 (>=0.25.5). If you want this functionality, you'll have to cherry-pick the commit and build a custom image of the operator for your workflows.