Skip to content

Support aliases in parametrized view function (only new analyzer)#65190

Merged
novikd merged 12 commits into
masterfrom
support-aliases-in-param-view-function
Jun 27, 2024
Merged

Support aliases in parametrized view function (only new analyzer)#65190
novikd merged 12 commits into
masterfrom
support-aliases-in-param-view-function

Conversation

@kssenii

@kssenii kssenii commented Jun 12, 2024

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support aliases in parametrized view function (only new analyzer)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@kssenii kssenii force-pushed the support-aliases-in-param-view-function branch from 087a10f to 0302741 Compare June 12, 2024 17:28
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-improvement Pull request with some product improvements label Jun 12, 2024
@robot-clickhouse-ci-2

robot-clickhouse-ci-2 commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

This is an automated comment for commit 7a57347 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Cloud fork sync (only for ClickHouse Inc. employees)If it fails, ask a maintainer for help✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckChecks correctness of the PR's body✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

Comment thread tests/queries/0_stateless/03167_parametrized_view_with_cte.sql Outdated
Comment thread src/Analyzer/Resolve/QueryAnalyzer.cpp Outdated
@kssenii kssenii force-pushed the support-aliases-in-param-view-function branch from 7baeb26 to 660e7f8 Compare June 18, 2024 09:08
@kssenii kssenii requested a review from novikd June 18, 2024 09:08
Comment thread src/Analyzer/Resolve/QueryAnalyzer.cpp Outdated
Comment thread src/Analyzer/Resolve/QueryAnalyzer.cpp Outdated
Comment thread tests/queries/0_stateless/03167_parametrized_view_with_cte.sql Outdated
@novikd novikd added the analyzer Issues and pull-requests related to new analyzer label Jun 18, 2024
@kssenii kssenii force-pushed the support-aliases-in-param-view-function branch from c679087 to 73c0a65 Compare June 19, 2024 17:05
@kssenii kssenii marked this pull request as draft June 20, 2024 10:59
@kssenii kssenii marked this pull request as ready for review June 20, 2024 11:40
@kssenii kssenii force-pushed the support-aliases-in-param-view-function branch from 35f6127 to c424fcd Compare June 20, 2024 11:43
@kssenii kssenii requested a review from novikd June 20, 2024 11:44

@novikd novikd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to make it work as it should. Let's see what the result of CI would be.

We skip invalid parametrized view arguments right now, but we should probably throw an exception. This particular change breaks the old behavior.

Comment thread src/Interpreters/Context.h Outdated
@novikd

novikd commented Jun 27, 2024

Copy link
Copy Markdown
Member

Stateless tests (debug) [5/5] — Timeout 10800 exceeded

#65754

@novikd novikd added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit 575f2ec Jun 27, 2024
@novikd novikd deleted the support-aliases-in-param-view-function branch June 27, 2024 07:15
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 27, 2024
shiyer7474 pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 11, 2024
…n-param-view-function

Support aliases in parametrized view function (only new analyzer)
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Oct 14, 2024
…_aliases_in_parameterized_view_function

24.3 Backport of PR ClickHouse#65190: Support aliases in parametrized view function (only new analyzer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analyzer Issues and pull-requests related to new analyzer pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants