Skip to content

fix: better errors for sso login#6113

Merged
0xi4o merged 7 commits into
mainfrom
fix/sso
Apr 3, 2026
Merged

fix: better errors for sso login#6113
0xi4o merged 7 commits into
mainfrom
fix/sso

Conversation

@0xi4o

@0xi4o 0xi4o commented Apr 1, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-04-01.at.9.06.55.PM.mov

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the error handling in the SSO login process to dynamically display error messages instead of a hardcoded string. A security concern was raised regarding the potential disclosure of sensitive information by exposing raw error messages from generic Error instances; it is recommended to only expose messages from specific, intentional error types like InternalFlowiseError.

Comment thread packages/server/src/enterprise/sso/SSOBase.ts
0xi4o and others added 2 commits April 1, 2026 21:10
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@HenryHengZJ

Copy link
Copy Markdown
Contributor

still having the same message for me, I thought I should able to see no such subscription too?
image

@0xi4o

0xi4o commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@HenryHengZJ I was just testing something so reverted it temporarily. Will build a new image and deploy again.

@0xi4o

0xi4o commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@HenryHengZJ reverted and deployed again.

Screenshot 2026-04-01 at 11 44 15 PM

@0xi4o 0xi4o merged commit cb1e1e3 into main Apr 3, 2026
8 checks passed
@0xi4o 0xi4o deleted the fix/sso branch April 3, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants