Add unstable_offset_of feature to use the unstable offset_of macro#72
Merged
Conversation
7 tasks
Gilnaa
reviewed
May 17, 2023
Gilnaa
approved these changes
May 17, 2023
Owner
|
Thank you very much. |
Contributor
Author
|
Thanks @Gilnaa for the fast review! ❤️ |
Owner
|
Failed to remember that night :) |
RalfJung
reviewed
May 19, 2023
Contributor
Author
|
@Gilnaa thanks for having done the release! |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a cargo feature
unstable_offset_ofto use the unstablecore::mem::offset_of!()macro (rust-lang/rust#106655). This allows for unsized structs (#25) and many other things. It also helps with testing of the upstreamoffset_ofmacro: testing is now as easy as enabling this feature, one doesn't have to change the usages frommemoffset::offset_oftocore::mem::offset_of.