Skip to content

misc(proto): add ConfigSettings fields#15616

Merged
paulirish merged 21 commits into
mainfrom
proto-configsettings
Oct 7, 2025
Merged

misc(proto): add ConfigSettings fields#15616
paulirish merged 21 commits into
mainfrom
proto-configsettings

Conversation

@paulirish

Copy link
Copy Markdown
Member

fixes #15193

I adapted the suggested syntax quite a bit. But... it's now happy for python, go, and C++ protobuf handling.

with the additions we can delete some of the hax in proto-processors (which is used in LR)

@paulirish paulirish requested a review from a team as a code owner November 16, 2023 20:03
@paulirish paulirish requested review from adamraine and removed request for a team November 16, 2023 20:03
@adamraine adamraine changed the title proto: add ConfigSettings fields. misc(proto): add ConfigSettings fields. Nov 16, 2023
@brendankenny

brendankenny commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Probably good to incentivize stability, but this means we can't change these types later (e.g. string to a struct or whatever), just retire them and pick a new name, right?

Also does it matter if e.g. auditMode/gatherMode are bool in the proto but really boolean | string? string is unusual outside of development of LH itself but it is possible depending on how the person is generating their LHRs (I'm assuming smokerider won't run into this?).

@connorjclark connorjclark changed the title misc(proto): add ConfigSettings fields. misc(proto): add ConfigSettings fields Jan 26, 2024
@connorjclark

Copy link
Copy Markdown
Collaborator

lets drop auditMode/gatherMode for now

Comment thread proto/README.md
Comment thread proto/README.md Outdated
paulirish and others added 2 commits October 6, 2025 14:03
@paulirish paulirish merged commit f9159f9 into main Oct 7, 2025
32 of 33 checks passed
@paulirish paulirish deleted the proto-configsettings branch October 7, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proto file missing fields

5 participants