[GUI] Move "View" menu out of the hamburger menu#1471
Conversation
Uses 'view-reveal-symbolic'.
Creates a separate button for the View menu, making it easier to access. Part of #1428.
Screencast.from.19-05-2025.19.52.49.webm |
|
Build failing due to formatting again, no idea why. |
|
To be fair, I'd probably also move the Ruler Units menu out of the View menu and into a specific button/dropdown that'd be drawn in the ruler itself. Not sure where exactly tho. Maybe for a future MR. |
| PintaCore.Actions.Edit.RegisterActions (app, edit_menu); | ||
| this.menu_bar.AppendSubmenu (Translations.GetString ("_Edit"), edit_menu); | ||
|
|
||
| var view_menu = Gio.Menu.New (); |
There was a problem hiding this comment.
This shifted the ordering of the menus when using a menu bar - the view menu is now appearing after Layers instead of after Edit
For muscle memory I think we should keep the existing menu bar order
There was a problem hiding this comment.
My bad, I tested the presence of the View menu in the menubar, but forgot to test the order. Fixed.
| public const string ToolZoom = "tool-zoom-symbolic"; | ||
|
|
||
| public const string ViewGrid = "view-grid"; | ||
| public const string ViewMenu = "view-reveal-symbolic"; |
There was a problem hiding this comment.
The icon worked fine for me on macOS 👍
For organization purposes, since this isn't a custom icon it should go into StandardIcons and be named ViewReveal to match the underlying icon name
I can also run Re: rulers, yeah that could be something to think about for a future change. Maybe it goes in the status bar or somewhere like that to avoid adding more clutter around the canvas? Since there are lots of widgets already on the left and top side from the tools and the toolbar |
Seems like it was Github's web UI adding identation in one of the comments and breaking formatting because of it. Now it seems fixed! |
|
👍 thanks! |
|
@pedropaulosuzuki Just an FYI: Adwaita offers icons for "eye" / View strings, might be better to reference from the Icon Library flatpak app:
But feel free to tag me in future MRs if you need any Adwaita-adjacent icons not currently available. Would be ideally nice to keep all icons as Adwaita as possible, if @cameronwhite is also good with it |
I actually used GNOME's Icon Library to find an appropriate icon, and
|
Yeah, For reference:
|
That's actually on my plans. I was thinking on moving the image to the right and having an eye on the left, but didn't open an issue about it yet. The idea would be to allow more icons to be added, like adding effects directly by clicking there instead of on the header bar (even if destructive, I guess it makes more sense to be there. Of course, it could evolve to #1405 at some point). |
That's a good plan, we could also have a companion open/closed padlock icon next to the eye for locking layers, but that's outside the scope of this MR. (if you ever start an open-ended UI/UX improvement issue like #1405 , I'd love to brainstorm together and create checklists for different sections) |
Agreed, seems like a good idea!
Are you on Matrix Chat? If so, please reach out! Brainstorming is always welcomed, not only for Pinta, but for FOSS projects in general! |
|
@cameronwhite Zoom In/Out also feels a bit redundant, as there are already the buttons -/+ at the bottom. Worth to remove? Also "Normal Size" is "100%" and "Best Fit" is "Window" (those two, we'd need to show the shortcuts better if we remove them).
Also, Inkscape has shortcuts for hiding the toolbar (Shift+F11) and side panels (F12), maybe if we implement something similar here (which would be good for quickly looking at the canvas without distractions), then they'd fit pretty well on the View menu, as F11 fullscreen is already there, for example. I'll open a separate issue for those later. |
|
I agree that Zoom In/Out are already accessible elsewhere, but I think it'd feel inconsistent if |
Okay, I will very soon! |
As discussed in #1471, we already have the zoom buttons in the bottom right corner, so having those in the menu just adds clutter, instead of actually presenting new menu options.
Creates a separate button for the View menu, making it easier to access (when compared to the current hamburger submenu solution). Doesn't change behavior when using the menubar.
Used the icon 'view-reveal-symbolic'. Not sure if it's always bundled with GTK/LibAdwaita or if it's a system icon that might cause problems on Windows/MacOS builds (if so, help needed here).
Part of #1428.