Added "Radius Percentage" setting in TwistEffect#1739
Conversation
|
Going beyond 100% seems reasonable to me if you want to expand the size of the twist effect more I'm not sure if I'm clear why that implies that bilinear sampling is necessary (although maybe we should be doing that regardless, especially since there are sub pixel samples for antialiasing) |
|
@cameronwhite, yes, I am referring to clamping (or reflecting/wrapping/etc.) the locations outside the image bounds. But there is a caveat when it comes to bilinear sampling: the methods in
|
|
I'd lean towards just switching those methods over to That can be a separate PR in the future, though, so this change seems good to merge |
For now it's <= 100, but later on we could try to allow percentages beyond 100 and/or moving the center of rotation by using
CairoExtensions.GetBilinearSampleClamped,CairoExtensions.GetBilinearSampleWrappedand so on