Checkerboard background for clear visualization of palette colors with transparency#1759
Merged
cameronwhite merged 5 commits intoSep 20, 2025
Merged
Checkerboard background for clear visualization of palette colors with transparency#1759cameronwhite merged 5 commits into
cameronwhite merged 5 commits into
Conversation
...And also `IChromeService`, instead of their concrete implementatons `PaletteManager` and `ChromeManager`. The `IPaletteService` interface had to be extended with the properties that this substitution requires.
Only draw checkered pattern if there is transparency
Member
|
Looks good ,thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code corresponding to the feature can be examined in 4367073.
On the way I also changed
StatusBarColorPaletteWidget(and related classes) to receiveIPaletteServiceinstead ofPaletteManager.I am selecting blue with an alpha of 128, and transparent. You can see the result by looking at the checkered spots:
Before this change these spots would have looked (in the case of dark mode) dark blue and very dark gray, like the background.
Note:
You will notice that I'm not showing a screenshot of the old behavior. I simply can't start Pinta anymore.If I try to rundotnet run --project Pintathe command returns with no output. I had to use the cloud build in order to run my changes, and even then I had to try in another computer, because neither 3.0.3 nor the development build would run of mine. And now neither of them runs on either computer.No combination of installing/uninstalling/restarting computer/building from source/cleaning .NET solution will get Pinta to run.I don't know what's going on. For context, both are Windows machines, one of them is Windows 10 and another one is Windows 11.Update: I got Pinta to run by deleting
AppData/Roaming/Pinta. This is what it looked like before this change, but after fixing the bug that prevented changing colors in the Palette (so 3.0.3 didn't work for this):Update: Commit 9082e84 adds this feature to the primary/secondary color swatches, too