Added new methods to gradients, and customization options to fractals that use them#678
Merged
cameronwhite merged 7 commits intoJan 13, 2024
Conversation
On a second thourhg, adding `init` is a bad idea, as the values have to go through a check, otherwise we can get invalid values
The user can adjust the hue later
Member
|
👍 I think just leaving it at allowing the user to reverse the gradient seems good. Can the Rotate methods also be removed to avoid introducing unused code? |
Contributor
Author
|
Yeah, no problem, they have been removed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the current selection of gradients for the fractals could be a bit dull, so what if we make it wider by adding customization options?
In the first commit, I added the option of reversing the gradient (turning the gradient upside down):
At some point I added the option of rotating the hue of the colors in the gradient. However, in the last commit I removed the
HueRotationproperty in theEffectData. because the user can just use Adjustments > Hue / Saturation; but if you think that keeping that property is a good idea, you could drop the last commit.