Added "Offset Selection" action#746
Merged
Merged
Conversation
taken from google material design icons https://github.com/google/material-design-icons
Contributor
Author
|
I have noticed that the code formatting check for Ubuntu wasn't successful, but that should be an unrelated problem and not caused by my pull request. Shouldn't be too bad, the build checks all work anyway. |
cameronwhite
left a comment
Member
There was a problem hiding this comment.
This looks very good, thank you!
I think the formatting issue might be from having incorrect line endings?
Contributor
Author
|
There you go. So in the end it was caused by my PR, my bad. For future reference, run the command " |
Member
|
Looks good, thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, i have added the GUI option for offsetting the selection in the edit tab, finally closing my issue (#661).
Similarly to last time, I have tried my best to respect the project flow, but feel free to point out if i did something wrong.
I will add an icon for the action in a next commit if i manage to find one, but for now i will just use the same icon of the "invert selection" option.