Bug fix: Eraser tool does not initialize to last-used mode#839
Merged
cameronwhite merged 1 commit intoJun 4, 2024
Merged
Conversation
Member
|
Thanks for catching this! Would it also work to instead just swap the ordering of the existing code, ie. adding the |
Contributor
Author
|
Good question, I'll check :-) |
… initializing it to the saved eraser type, so that eraser_type gets set to that value during initialization.
dd7eada to
de85e86
Compare
Contributor
Author
|
Seems to work :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a combobox which does initialize to the last-used mode, but the value doesn't actually get stashed into the tool's state, so until you interact with it, it's still in the default state. In practice, this means that if you use the eraser tool and set it to
Smoothmode, then you restart Pinta, the combo box remembers that it should be inSmoothmode, but the tool initially operates inNormalmode.This PR sets the tool's state to match the value loaded into the combo box.