wasm2c: Add segue option to make exclusive use of the segment register#2458
Merged
Conversation
Collaborator
Author
|
@sbc100 Please have a look when you have the chance. This should be the last segue commit prior to us deploying in Firefox. |
sbc100
reviewed
Sep 18, 2024
8f7a227 to
642b76f
Compare
sbc100
approved these changes
Sep 18, 2024
642b76f to
c5c959a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3rd of the 3 PRs needed for production Linux Segue support (i.e., use x86 segment registers to refer to the Wasm heap for single-memory Wasm modules). This PR adds an option for applications to tell wasm2c that it has exclusive use of the gs register for this purpose and need not save and restore it on each use --- something that is particularly expensive on pre-Ivybridge CPUs which requires syscalls to set segment registers.