Skip to content

test(interp): Move legacy exception handling tests (NFC)#2498

Merged
keithw merged 2 commits into
WebAssembly:mainfrom
SoniEx2:ehv4-defs
Oct 31, 2024
Merged

test(interp): Move legacy exception handling tests (NFC)#2498
keithw merged 2 commits into
WebAssembly:mainfrom
SoniEx2:ehv4-defs

Conversation

@SoniEx2

@SoniEx2 SoniEx2 commented Oct 29, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@sbc100

sbc100 commented Oct 30, 2024

Copy link
Copy Markdown
Member

It looks like maybe we can completely remove third_party/testsuite_legacy now that WebAssembly/testsuite#81 has been merged?

@SoniEx2

SoniEx2 commented Oct 30, 2024

Copy link
Copy Markdown
Collaborator Author

would have to update testsuite first

@sbc100

sbc100 commented Oct 30, 2024

Copy link
Copy Markdown
Member

Ah I see. Do you still want to land this change first?

@SoniEx2

SoniEx2 commented Oct 30, 2024

Copy link
Copy Markdown
Collaborator Author

yeah, think it would be easier this way.

@sbc100 sbc100 enabled auto-merge (squash) October 30, 2024 21:59
@sbc100

sbc100 commented Oct 30, 2024

Copy link
Copy Markdown
Member

Can you rebase and this should then auto-merge

@sbc100 sbc100 closed this Oct 30, 2024
auto-merge was automatically disabled October 30, 2024 22:00

Pull request was closed

@sbc100 sbc100 reopened this Oct 30, 2024
@sbc100 sbc100 enabled auto-merge (squash) October 30, 2024 22:00
auto-merge was automatically disabled October 30, 2024 22:06

Head branch was pushed to by a user without write access

@SoniEx2

SoniEx2 commented Oct 30, 2024

Copy link
Copy Markdown
Collaborator Author

you forgot this:

auto-merge was automatically disabled
Head branch was pushed to by a user without write access

but anyway

@keithw keithw enabled auto-merge (squash) October 31, 2024 03:14
@keithw keithw merged commit da297e0 into WebAssembly:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants