Add support for the custom-page-sizes proposal#2502
Merged
Conversation
7e4c060 to
c28be4f
Compare
c28be4f to
17904af
Compare
This adds support in the binary/text parsers and writers, the validator and interpreter, and objdump (but not wasm2c).
17904af to
e2429a9
Compare
sbc100
approved these changes
Nov 7, 2024
fitzgen
reviewed
Nov 7, 2024
fitzgen
left a comment
There was a problem hiding this comment.
Very cool! Love to see it! I'll add a link to this PR from the proposal's Overview.md.
|
FWIW, if you want to hammer on this implementation a bit, You can throw that in a loop, pass each test case to WABT, and see if you can find any bugs :) (There are also lots of other knobs you can configure to control Wasm module generation, for example you can disable random imports to make the modules self contained, turn off the GC proposal, etc...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the custom-page-sizes proposal to the lexer, the binary/text parsers and writers, the validator, interpreter, and objdump.
Will plan to add wasm2c in a future PR.
(@fitzgen)