test/run-roundtrip.py: test roundtrip even with --stdout#2505
Merged
Conversation
shravanrn
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1661, run-roundtrip.py always converts wat0 -> wasm1 -> wat2 -> wasm3 and fails if any of the conversions fails. With the
--stdoutargument, it then prints the wat2 file; otherwise, it compares the wasm1 and wasm3 binaries and fails if they're different.This PR makes the roundtrip comparison always happen (even with
--stdout), unless an argument is given that asks wat2wasm to change the binary on purpose (in particular:--generate-names, which changes the name section, or--inline-exportswhich can reorder exports).This didn't catch any bugs, but it gives some more test coverage.
(@SoniEx2)