Update testsuite submodule#2549
Merged
Merged
Conversation
sbc100
approved these changes
Mar 2, 2025
sbc100
left a comment
Member
There was a problem hiding this comment.
I wonder what we will have to resort to once wasm-3.0 merges into the main branch?
Member
Author
|
I guess it doesn't seem like anybody is jumping up to implement conforming GC in WABT (which would probably be a lot of work). My sense is that the most likely graceful evolution would probably be to port wasm2c over to the Bytecode Alliance wasm-tools codebase (in Rust) and improve wasm-tools's "wat2wasm" and "wasm2wat" subtools so they can substitute for WABT's. :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR vendors the old "memory64" tests into "test/old-spec" and runs them from there, then updates the testsuite submodule. We skip the new "wasm-3.0" tests (which rely on function-references and gc).