wasm2c: Fix platform specific mutex support#2566
Merged
Merged
Conversation
sbc100
approved these changes
Mar 19, 2025
sbc100
left a comment
Member
There was a problem hiding this comment.
Sad to learn about the state of C11 threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started testing the wasm2c code a bit more on FreeBSD and found issues with using C11 mutexes. Unfortunately, the C11 mutex APIs seems to be supported almost nowhere. Apple doesn't support it, FreeBSD doesn't support it (hence wasm2c examples actually fail on FreeBSD until this change), Windows doesn't support it till very recently. We are better off simply relying on platform specific primitives:
CRITICAL_SECTIONon windows,pthread_mutex_teverywhere else.