Skip to content

wasm2c: Mmap+guard on big-endian won't move memory (fix #2599)#2602

Merged
shravanrn merged 2 commits into
WebAssembly:mainfrom
PLSysSec:w2c-s390x
Jun 12, 2025
Merged

wasm2c: Mmap+guard on big-endian won't move memory (fix #2599)#2602
shravanrn merged 2 commits into
WebAssembly:mainfrom
PLSysSec:w2c-s390x

Conversation

@shravanrn

Copy link
Copy Markdown
Collaborator

No description provided.

@shravanrn shravanrn requested review from SoniEx2, keithw and sbc100 May 17, 2025 02:06
@shravanrn shravanrn force-pushed the w2c-s390x branch 5 times, most recently from 3ee91d7 to e1c6a86 Compare May 17, 2025 09:22
@shravanrn shravanrn marked this pull request as draft May 17, 2025 09:52
@shravanrn shravanrn force-pushed the w2c-s390x branch 2 times, most recently from 8f4d9a4 to 7f748a8 Compare May 17, 2025 12:44
@shravanrn shravanrn marked this pull request as ready for review May 17, 2025 13:19
@shravanrn

Copy link
Copy Markdown
Collaborator Author

Sorry, it took a few iterations to get all the tests passing. Looks like things are working now.

@shravanrn

Copy link
Copy Markdown
Collaborator Author

@sbc100 @keithw any chance one of you could review this pr?

Comment thread wasm2c/wasm-rt-mem-impl-helper.inc Outdated
Comment thread wasm2c/wasm-rt.h Outdated
Comment thread wasm2c/wasm-rt-mem-impl-helper.inc Outdated
Comment thread wasm2c/examples/fac/fac.c
Comment thread wasm2c/wasm-rt-impl.c
@shravanrn shravanrn merged commit f976380 into WebAssembly:main Jun 12, 2025
18 checks passed
@shravanrn shravanrn deleted the w2c-s390x branch June 12, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants