wasm2c: fix big endian guard page support#2621
Merged
Merged
Conversation
sbc100
approved these changes
Jun 16, 2025
sbc100
left a comment
Member
There was a problem hiding this comment.
lgtm, but are you trying to fix this just to make CI happy are your using s390 yourself in production. (If that latter I wonder how much effort it is worth investing here).
Collaborator
Author
@sbc100 There is an effort to make sure Firefox works well in the s390x. A part of that effort was to see if the wasm2c-based RLBox library sandboxing works there as well. It's not the highest priority item, but I'm cleaning up the support in the chance that this is something that can get adopted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.