fix mismatch between ExprTypeName and ExprType#2632
Merged
sbc100 merged 4 commits intoSep 16, 2025
Merged
Conversation
…s://github.com/Inginnng/wabt into fix/mismatch_between_ExprTypeName_and_ExprType
sbc100
reviewed
Sep 15, 2025
sbc100
left a comment
Member
There was a problem hiding this comment.
lgtm.
I guess we don't have any tests that cover this?
Member
|
Looking into the CI issues here: #2633 |
Contributor
Author
|
fine, I found a timeout issue after uploading yesterday. I conducted three local tests, and the timeout error did not occur in any of them. and, I am not using macOS. so I didn't find the error in macOS build. thx for answering the CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2631 There is an inconsistency between the order of enum values in
ExprType(defined inir.h) and the corresponding string names inExprTypeNamearray (defined inir.cc). This causesGetExprTypeName()to return incorrect string representations for atomic operation related expression types.In
ir.h(ExprTypeenum):In
ir.cc(ExprTypeNamearray):The error occurs in these functions:
In
ir.cc: