Fix reference tracking in SharedValidator#2672
Merged
Merged
Conversation
Clear "reference is set" bitset and hasmap in BeginFunctionBody Furtermore support try_tables
sbc100
approved these changes
Nov 23, 2025
Member
|
Thanks for the quick fix! |
zherczeg
commented
Nov 23, 2025
| TypeVector param_types, result_types; | ||
| result |= CheckBlockSignature(loc, Opcode::TryTable, sig_type, ¶m_types, | ||
| &result_types); | ||
| RestoreLocalRefs(result); |
Collaborator
Author
There was a problem hiding this comment.
I realized I misunderstood how BeginTryTable/EndTryTable work. This is a new part of the code for me. BinaryReaderInterp::OnTryTableExpr calls EndTryTable after catch blocks are processed, not after the end.
In this case this is not needed (although harmless), and the normal OnEnd should call RestoreLocalRefs (it does).
I am sorry, I will submit another fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear "reference is set" bitset and hasmap in BeginFunctionBody.
Furtermore support try_tables.
Fixes: #2670