Implement quoted identifier parsing#2715
Merged
Merged
Conversation
Collaborator
Author
|
This patch is bigger than I hoped for, but at least not complex. |
sbc100
approved these changes
Mar 12, 2026
sbc100
left a comment
Member
There was a problem hiding this comment.
Are these new test still going to be needed/useful once we update the testsuite to 3.0?
Or are they going to be redundant? If so maybe add comments to remove them once we update?
Collaborator
Author
|
More tests are always useful I think. And they test the error message as well, not just the operation. Can I land the patch? |
Member
|
Yup, feel free to land if you have LGTM and tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that webassembly 3.0 support
$"quoted identifiers". It seems it is part of the annotations proposal:https://github.com/WebAssembly/annotations/blob/main/proposals/annotations/Overview.md
Extend the grammar of identifiers as follows:
id ::= "$"idchar+ | "$"nameThis patch should add support for it.