Remove debug-parser option and other unused variables#2739
Merged
Conversation
sbc100
reviewed
Apr 6, 2026
| s_log_stream = FileStream::CreateStderr(); | ||
| }); | ||
| parser.AddOption("debug-parser", "Turn on debugging the parser of wast files", | ||
| []() { s_debug_parsing = true; }); |
Member
There was a problem hiding this comment.
Did this flag used to work in the past? Maybe we should make it work rather than removing it?
Collaborator
Author
There was a problem hiding this comment.
What does it do? It is added here, replacing another flag:
bc3deb3
Collaborator
Author
There was a problem hiding this comment.
parser.AddOption("debug-parser", "Turn on debugging the parser of wast files",
- []() { s_parse_options.debug_parsing = true; });
+ []() { s_debug_parsing = true; });
This was the actual change
Collaborator
Author
There was a problem hiding this comment.
A flag still present here, but it seems nothing is using it.
https://github.com/WebAssembly/wabt/blob/main/include/wabt/wast-parser.h#L37
Perhaps some plans changed?
sbc100
reviewed
Apr 6, 2026
| s_log_stream = FileStream::CreateStderr(); | ||
| }); | ||
| parser.AddOption("debug-parser", "Turn on debugging the parser of wat files", | ||
| []() { s_debug_parsing = true; }); |
1742eb4 to
c3256a3
Compare
Member
|
It looks like the debug parser setting was removed back in #591 when the parser was re-written. So I think its safe to remove these command line flags, but maybe mention that in the PR description and maybe even add to the PR title? |
The support for --debug-parser is removed from the project after the parser has been reworked. This patch removes the command line option as well.
sbc100
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The support for --debug-parser is removed from the project after the parser has been reworked. This patch removes the command line option as well.
Would not be bad to change the
"Use multiple times for more info"to something else.