Enhance experience when installing and activating a standalone plugin#900
Merged
Conversation
swissspidy
reviewed
Dec 12, 2023
felixarntz
requested changes
Dec 12, 2023
felixarntz
left a comment
Member
There was a problem hiding this comment.
Thanks @mukeshpanchal27, it's great you found a solution for this problem. I left a bit of feedback below, but the overall approach looks solid.
westonruter
reviewed
Dec 12, 2023
felixarntz
reviewed
Dec 13, 2023
westonruter
reviewed
Dec 13, 2023
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Member
Author
|
Thank you, @felixarntz, @swissspidy, and @westonruter, for your feedback. I have addressed it, and the PR is now ready for review. |
westonruter
reviewed
Dec 14, 2023
westonruter
reviewed
Dec 14, 2023
westonruter
reviewed
Dec 14, 2023
westonruter
reviewed
Dec 14, 2023
felixarntz
reviewed
Dec 14, 2023
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> Co-authored-by: Weston Ruter <westonruter@google.com>
Member
Author
|
@felixarntz @westonruter, I identified an edge case while installing multiple plugins and try to activate first plugin where we encountered an incorrect selector in |
felixarntz
approved these changes
Dec 15, 2023
felixarntz
left a comment
Member
There was a problem hiding this comment.
Great work @mukeshpanchal27!
Only one minor thing that would be good to address, but not a blocker.
westonruter
previously requested changes
Dec 15, 2023
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Member
Author
|
@swissspidy Could you kindly take a moment to review the recent changes? |
swissspidy
approved these changes
Dec 18, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #880
admin/perflab-admin.jsfile.update.jsupdates plugin activation link in 1 sec so in our custom script we will update it after 1.5 sec.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.