post-action warning on revoke failure in case token already expired

[danra]

I'm seeing the following warning in the post job cleanup step:

Post job cleanup.
Warning: Token revocation failed: Bad credentials - https://docs.github.com/rest

Probably because the token was already invalidated, because the job took more than 1h to run (see #121).

No issue here other than there shouldn't be any warning in this case.

[gr2m]

We do already check for expiration time, maybe we got it implemented wrong though?

create-github-app-token/lib/post.js

Lines 24 to 28 in c8f55ef

	const expiresAt = core.getState("expiresAt");
	if (expiresAt && tokenExpiresIn(expiresAt) < 0) {
	core.info("Token expired, skipping token revocation");
	return;
	}

[dboriichuk]

I just want to +1 to this issue.
It happens in jobs, which runs for several hours.

[gr2m]

thanks for letting us know @dboriichuk. That suggests that our expiration check is not working. I'll add more logs to get to the bottom of it

[create-app-token-action-releaser]

🎉 This issue has been resolved in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀