Reduce size by new url generation and counter reuse#170
Merged
Conversation
|
You forgot about |
ai
reviewed
Jan 28, 2020
ai
reviewed
Jan 29, 2020
ai
reviewed
Jan 29, 2020
ai
reviewed
Jan 29, 2020
ai
reviewed
Jan 29, 2020
Anber
reviewed
Jan 29, 2020
Owner
|
Ещё нужно сравнить результаты |
Contributor
Author
|
Owner
|
Released in 2.1.11 |
alfaproject
reviewed
Feb 1, 2020
Comment on lines
+29
to
+30
| var bytes = crypto.getRandomValues(new Uint8Array(size || 21)) | ||
| i = size || 21 |
There was a problem hiding this comment.
Why not?
i = size || 21
var bytes = crypto.getRandomValues(new Uint8Array(i))
Contributor
Author
There was a problem hiding this comment.
For better gzip compression. It makes +1 byte.
Contributor
Author
There was a problem hiding this comment.
Sorry, I was wrong. +3 bytes :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Url generation based on @anber_ru's proposal.