You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
@beryllw Thanks for the PR. Only left minor comments. Otherwise, LGTM.
Besides, could you please verify this pr in your own env to make this pr fix the problem that the issue describes.
Could you please verify this pr in your own env to make this pr fix the problem that the issue describes.
Yes. I encountered an issue where plugin HDFS and Paimon can't use Kerberos authentication with the plugin class loader. We might need a PR to fix this. Additionally, shading org.apache.commons is necessary to prevent conflicts between Fluss and the Hadoop dependencies on the machine.
Plugin HDFS and Paimon can't use Kerberos authentication with the plugin class loader.
By setting plugin.classloader.parent-first-patterns.default=java.,com.alibaba.fluss.,javax.annotation.,org.slf4j,org.apache.log4j,org.apache.logging,org.apache.commons.logging,ch.qos.logback,hdfs-site,core-site,org.apache.hadoop.,META-INF to include the necessary patterns, the problem can be resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1168
Brief change log
Use plugin classloader as thread current classloader, and ensure LakeStoragePlugin uses the plugin classloader for all operations
Tests
com.alibaba.fluss.lake.lakestorage.LakeStorageTest
API and Format
Documentation