[hotfix] Use literal directly instead of PARTITION_GENERATE_LEGCY_NAME to avoid NoSuchField error#1880
Conversation
…ON_GENERATE_LEGCY_NAME to avoid NoSuchField error
|
+1 |
| // use literal directly, a future paimon version will rename | ||
| // the variable PARTITION_GENERATE_LEGCY_NAME to PARTITION_GENERATE_LEGACY_NAME, use literal | ||
| // can help avoid NoSuchField error | ||
| PAIMON_UNSETTABLE_OPTIONS.add("partition.legacy-name"); |
There was a problem hiding this comment.
also modified PARTITION_GENERATE_LEGCY_NAME in setPaimonDefaultProperties
There was a problem hiding this comment.
+1， looks like paimon has a typo LEGCY vs LEGACY
There was a problem hiding this comment.
I still don't want to modified. Keep PARTITION_GENERATE_LEGCY_NAME can help us find problem quickly(compile will fail) if Paimon remove PARTITION_GENERATE_LEGCY_NAME since we does rely on paimon's behavior of PARTITION_GENERATE_LEGCY_NAME.
Since it's a tempory hacky fix since it's a typo of paimon, after we ungrade paimon to higer version, we can fall back to use PARTITION_GENERATE_LEGACY_NAME again, which I believe won't be changed in paimon
There was a problem hiding this comment.
LOL, I just pointed out a typo in paimon and we should fix it in paimon project in a compatible way instead of using the internal key here.
There was a problem hiding this comment.
Let's change all to literal to make ervery thing consistent. If paimon remove this optioin, the existing test should discover it.
…E to avoid NoSuchField error (apache#1880)
Purpose
Linked issue: close #xxx
Use literal directly instead of PARTITION_GENERATE_LEGCY_NAME to avoid NoSuchField error when mix with a paimon with higher version which has changed
PARTITION_GENERATE_LEGCY_NAMEtoPARTITION_GENERATE_LEGACY_NAMEBrief change log
Tests
API and Format
Documentation