[hotfix][client] Fix potential metadata inconsistency by deduplicating getBucketLocation call#1897
Merged
Merged
Conversation
leonardBang
reviewed
Oct 30, 2025
| private Integer getTableBucketLeader(TableBucket tableBucket) { | ||
| if (metadataUpdater.getBucketLocation(tableBucket).isPresent()) { | ||
| BucketLocation bucketLocation = metadataUpdater.getBucketLocation(tableBucket).get(); | ||
| Optional<BucketLocation> bucketLocationOpt = metadataUpdater.getBucketLocation(tableBucket); |
Contributor
There was a problem hiding this comment.
IIUC, here we want to call metadataUpdater.getBucketLocation once to make sure the status consistence. Could you change the commit message to [hotfix][client] Fix potential metadata inconsistency by deduplicating getBucketLocation call ?
Btw, we can also search similar places in client.
Contributor
Author
There was a problem hiding this comment.
Done! I have checked the callers of MetadataUpdater and confirmed that there are no other inconsistent invocations.
…g getBucketLocation call
bce8643 to
73e7dbb
Compare
leonardBang
approved these changes
Oct 30, 2025
leonardBang
left a comment
Contributor
There was a problem hiding this comment.
Thanks @swuferhong for the update and check, LGTM
swuferhong
added a commit
to swuferhong/fluss
that referenced
this pull request
Oct 31, 2025
…g getBucketLocation call (apache#1897)
Ugbot
pushed a commit
to Ugbot/fluss
that referenced
this pull request
Apr 26, 2026
…g getBucketLocation call (apache#1897)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pr is aims to fix the
NoSuchElementExceptionthrow at client when upgrading cluster:Brief change log
Tests
API and Format
Documentation