[release] Fix missing LICENSE and DISCLAIMER in binary distribution#1922
Conversation
| $MVN clean package -Prelease -am -Dgpg.skip -Dcheckstyle.skip=true -DskipTests | ||
|
|
||
| cd fluss-dist/target/fluss-${RELEASE_VERSION}-bin | ||
| cp ${FLUSS_DIR}/LICENSE ./fluss-${RELEASE_VERSION}/LICENSE |
There was a problem hiding this comment.
That's the LICENSE from the source distribution right ?
I guess we need a specific one for the binary distribution (as we bundle dependencies).
Maybe we can do another PR specifically for LICENSE and NOTICE in the binary distribution.
There was a problem hiding this comment.
Yes, this copies LICENSE file from source code to the binary distribution to fix the missing LICENSE in binary distribution. I think the LICENSE file in source distribution is correct, right?
The NOTICE file already exists in binary distribution, this PR just append the NOTICE content in source code into the existing binary NOTICE file.
|
Hi @jbonofre, I’ve tested the PR locally, and it correctly generates the LICENSE and DISCLAIMER files in the binary distribution. I’ll go ahead and merge this for now. If anything is missing or needs refinement, I’ll follow up with additional PRs.
|
|
Yeah I will create another PR because the LICENSE is correct for source distribution but not binary distribution |

Purpose
This fixes the release issues mentioned by JB in the vote thread: https://lists.apache.org/thread/pyccbmxoz9wnf6m3blcrcvj8j9gzyow8
Linked issue: close #xxx
Brief change log
create_binary_release.shto copy the DISCLAIMER and LICENSE from the project root directory.Tests
API and Format
Documentation