[helm] Enable metrics reporting on helm charts#2711
Merged
Conversation
1f83844 to
c42ce9a
Compare
affo
reviewed
Mar 2, 2026
affo
left a comment
Contributor
There was a problem hiding this comment.
Amazing, thank you!
Some nits here in there, very punctual.
affo
suggested changes
Mar 6, 2026
584c536 to
f91ef73
Compare
affo
reviewed
Mar 9, 2026
5d8b718 to
706cd7e
Compare
affo
reviewed
Mar 11, 2026
affo
left a comment
Contributor
There was a problem hiding this comment.
Many comments were marked resolved even though they were not.
affo
reviewed
Mar 13, 2026
affo
reviewed
Mar 13, 2026
affo
left a comment
Contributor
There was a problem hiding this comment.
I suggested a design that favors the config overrides and treats every option independently to avoid generic implementations that may fire back to us
ed064b6 to
1e6fee5
Compare
843e257 to
f4cca17
Compare
affo
suggested changes
Mar 17, 2026
affo
approved these changes
Mar 17, 2026
affo
left a comment
Contributor
There was a problem hiding this comment.
This is now damn good!
I think we are now having patterns that we can formalize better:
- forbid value in config override
- validate functions
I think we may have other follow-up PRs
Contributor
|
@swuferhong this should be ready now, can you give a look? |
--- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
wxplovecc
pushed a commit
to tongcheng-elong/fluss
that referenced
this pull request
Apr 17, 2026
--- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
wxplovecc
pushed a commit
to tongcheng-elong/fluss
that referenced
this pull request
Apr 20, 2026
--- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
polyzos
pushed a commit
that referenced
this pull request
Apr 23, 2026
* [helm] Enable pulling from private Docker registry (#2692) * [helm] Enable pulling from private Docker registry Added instructions for using a private Docker registry and included image values reference. --------- Co-authored-by: xx789 <348448708@qq.com> (cherry picked from commit 43f76a5) * [helm] Fix wrong resource name in coordinator sts (#2834) (cherry picked from commit 2c49fbc) * [helm] Add CI workflow to run Helm tests (#2777) * [helm] Add CI workflow to run Helm tests (cherry picked from commit dd181eb) * [Helm] Chart Component Configuration Isolation (#2472) * Helm Chart Component Configuration Isolation * Retrigger CI tests * Retriggering CI/CD build pipeline (cherry picked from commit d956e75) * [Helm] Revert Chart Component Configuration Isolation (#2472) (#2863) This reverts commit d956e75. (cherry picked from commit 8cd9a6f) * [helm] Enable SASL authentication configurations (#2506) (cherry picked from commit f7e4498) * [helm] Rewrite README to point to website docs (#2846) (cherry picked from commit aa5d166) * [helm][hotfix] Go template whitespace trimming caused exceptions (#2893) * [helm][hotfix] Go template whitespace trimming caused exceptions * Update and use without trimming (cherry picked from commit 22ece48) * [helm] Enable metrics reporting in helm charts (#2711) --- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com> (cherry picked from commit 2b207a4) * [helm] Fix .helmignore to not package tests (#2847) (cherry picked from commit d4748f2) * [helm] Enable SASL authenticated connection to Zookeeper nodes (#2700) --- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com> (cherry picked from commit bdbbbce) * [helm] Fix Zookeeper client config path (#3015) (cherry picked from commit e9bfd72) * [helm] Fix wrong resource name in coordinator sts (#3044) (cherry picked from commit 8df3873) * [helm] Add extraVolumes, extraVolumeMounts, initContainers (#3034) (cherry picked from commit 17f5400) --------- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com> Co-authored-by: xx789 <348448708@qq.com> Co-authored-by: Hemanth Savasere <hemanth.savasere@gmail.com>
Ugbot
pushed a commit
to Ugbot/fluss
that referenced
this pull request
Apr 26, 2026
--- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2677
Adds support for setting up the metrics on Helm chart values.
Brief change log
Tests
Using helm unit tests
API and Format
NA
Documentation
Added usage docs to the Deploying with Helm documentation