Skip to content

[lake/tiering] Add CoordinatorServer Monitoring Metrics for Lake Tiering Scheduling#2815

Merged
luoyuxia merged 2 commits into
apache:mainfrom
beryllw:lake-metrics-global
Mar 9, 2026
Merged

[lake/tiering] Add CoordinatorServer Monitoring Metrics for Lake Tiering Scheduling#2815
luoyuxia merged 2 commits into
apache:mainfrom
beryllw:lake-metrics-global

Conversation

@beryllw

@beryllw beryllw commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Purpose

Linked issue: close #2816

Brief change log

Scope: coordinator > lakeTiering (global)

Metric Type Description
pendingTablesCount Gauge Number of tables waiting to be tiered
runningTablesCount Gauge Number of tables currently being tiered

Tests

API and Format

Documentation

@beryllw beryllw changed the title [lake/tiering] Add Server-Level Monitoring Metrics for Lake Tiering [lake/tiering] Add CoordinatorServer Monitoring Metrics for Lake Tiering Scheduling Mar 9, 2026
@luoyuxia luoyuxia requested a review from Copilot March 9, 2026 09:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds global CoordinatorServer metrics to monitor lake tiering scheduling activity.

Changes:

  • Introduces a LakeTieringMetricGroup and wires it into CoordinatorServer / LakeTableTieringManager.
  • Registers two new gauges (pendingTablesCount, runningTablesCount) for lake tiering.
  • Updates docs and tests to reflect/validate the new metrics.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
website/docs/maintenance/observability/monitor-metrics.md Documents the new lake tiering coordinator metrics.
fluss-server/src/main/java/org/apache/fluss/server/metrics/group/LakeTieringMetricGroup.java Adds a dedicated metric group under the coordinator scope.
fluss-server/src/main/java/org/apache/fluss/server/coordinator/LakeTableTieringManager.java Registers gauges + adjusts locking to support safe metric reads.
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorServer.java Instantiates the tiering metric group and passes it to the manager.
fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java Adds metric name constants for the new gauges.
fluss-server/src/test/java/org/apache/fluss/server/metrics/group/TestingMetricGroups.java Provides a reusable LakeTieringMetricGroup for tests.
fluss-server/src/test/java/org/apache/fluss/server/coordinator/LakeTableTieringManagerTest.java Adds a test validating pending/running counts.
fluss-server/src/test/java/org/apache/fluss/server/coordinator/statemachine/TableBucketStateMachineTest.java Updates construction of LakeTableTieringManager to pass the metric group.
fluss-server/src/test/java/org/apache/fluss/server/coordinator/rebalance/RebalanceManagerTest.java Updates construction of LakeTableTieringManager to pass the metric group.
fluss-server/src/test/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessorTest.java Updates construction of LakeTableTieringManager to pass the metric group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luoyuxia luoyuxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beryllw Thanks for the pr.
Please also close tieringMetricGroup in LakeTableTieringManager

@beryllw beryllw force-pushed the lake-metrics-global branch from d861665 to 168b680 Compare March 9, 2026 09:52
@beryllw beryllw requested a review from luoyuxia March 9, 2026 11:07

@luoyuxia luoyuxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beryllw Thanks for update. LGTM

@luoyuxia luoyuxia merged commit 79fd2eb into apache:main Mar 9, 2026
7 checks passed
hemanthsavasere pushed a commit to hemanthsavasere/fluss that referenced this pull request Mar 14, 2026
wxplovecc pushed a commit to tongcheng-elong/fluss that referenced this pull request Apr 17, 2026
wxplovecc pushed a commit to tongcheng-elong/fluss that referenced this pull request Apr 20, 2026
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lake/tiering] Add CoordinatorServer Monitoring Metrics for Lake Tiering Scheduling

3 participants