Skip to content

fix: remove custom help that is breaking in production#201

Merged
Souvikns merged 3 commits into
asyncapi:masterfrom
Souvikns:fix-192
Jan 27, 2022
Merged

fix: remove custom help that is breaking in production#201
Souvikns merged 3 commits into
asyncapi:masterfrom
Souvikns:fix-192

Conversation

@Souvikns

Copy link
Copy Markdown
Member

Description
Removing custom help for now, as it is causing the CLI to break in production. oclif has updated and @oclif/plugin-help is now under @oclif/core so I think we could just update the whole CLI and remove @oclif/command and follow as per their documentation.

Related issue(s)

See also #192

@derberg derberg changed the title fix: fix cli breaking in production fix: remove custom help that is breaking in production Jan 26, 2022
derberg
derberg previously approved these changes Jan 26, 2022
@magicmatatjahu

Copy link
Copy Markdown
Member

As I see we have still "@oclif/plugin-help": "^3.2.3", in deps in this PR, I think we should remove that plugin, if we don't use it.

@Souvikns

Copy link
Copy Markdown
Member Author

I have removed the @oclif/plugin-help and it is still working as intended, I was under the impression that it needs that plugin for the help command to work.

@derberg derberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@imabp

imabp commented Jan 26, 2022

Copy link
Copy Markdown
Member

@Souvikns , is @oclif/plugin-help a wrapper over help command by oclif?

@Souvikns

Copy link
Copy Markdown
Member Author

No oclif/plugin-help is a plugin that handled the help command functionalities, but now it is already in core so we do not need this plugin anymore.

@imabp

imabp commented Jan 26, 2022

Copy link
Copy Markdown
Member

Thank you @Souvikns :) for the clarification

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns

Copy link
Copy Markdown
Member Author

Will merge this once @fmvilas approves.

Also, this is something that I found today #192 (comment)

@derberg

derberg commented Jan 27, 2022

Copy link
Copy Markdown
Member

No need to wait. You have it approved. It is a bug that makes CLI not work so yeah, merge it 🙂

@Souvikns Souvikns merged commit 1aba893 into asyncapi:master Jan 27, 2022
@fmvilas

fmvilas commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

Also, I'm not a code owner so don't wait for my approval. I'm observing this repo but not always participating 👀 😄

@asyncapi-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.12.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants