ci: Fix kernel downgrade to let scriptlets run with TMPDIR=/var/tmp#2198
Merged
Conversation
Undo hacky --noscripts - this was working around an rpm-ostree bug (working on a PR for that). Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies kernel provisioning and upgrade test logic, specifically updating the kernel downgrade process in 'hack/provision-fetch.sh' and removing manual 'dracut' execution in 'tmt/tests/Dockerfile.upgrade-source'. The review identifies critical issues: the removal of module cleanup in the provision script leads to image bloat, and the aggressive 'rm -rf /boot/*' command risks deleting necessary boot files. Additionally, the removal of the 'dracut' block in the Dockerfile may cause boot failures by failing to place the 'initrd' in the location expected by 'bootc'.
Johan-Liebert1
approved these changes
May 14, 2026
Johan-Liebert1
left a comment
Collaborator
There was a problem hiding this comment.
Reran failed jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undo hacky --noscripts - this was working around an rpm-ostree bug (working on a PR for that).
Assisted-by: OpenCode (claude-sonnet-4-6@default)