add browser field to avoid shimming crypto-browserify#364
Merged
Conversation
Contributor
Author
|
@evanvosberg can I get review on this tiny change? It is kind of blocking our usage of crypto-js now. Thank you. |
|
You can try jscrypto which solves various issues like you mentioned. |
This was referenced Jul 15, 2021
This was referenced Jul 22, 2021
This was referenced Sep 24, 2021
Merged
Mhmonicox
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on spec https://github.com/defunctzombie/package-browser-field-spec
Adding this can help solve several issues related to webpack/nextjs build, as it avoids shimming the
crypto-browserifywhen resolvingcrypto-js/core. Otherwise, user needs to manually update the resolving setting in their webpack/nextjs config.related issues:
#354
#276
aws-amplify/amplify-js#7570