build-resolution-cache: trim comments and consolidate tests#1
Merged
domenkozar merged 1 commit intoJun 23, 2026
Merged
Conversation
No functional change. Hoist a duplicated removeResolutionCache() call in the rpRemove path, drop comments that restate the code, and shorten the remaining ones to just the non-obvious WHY. Merge the four near-identical "edit drops the cache" / "stale note fails" test scripts into two, and cut the long test preambles down to a few lines each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional change. Tightens comments and merges near-identical test scripts; see commit message for details.