Skip to content

ci: fix unquoted expression in images-dev shell condition#3249

Merged
tklauser merged 1 commit into
cilium:mainfrom
immanuwell:ci/fix-images-dev-unquoted-sha
Jun 9, 2026
Merged

ci: fix unquoted expression in images-dev shell condition#3249
tklauser merged 1 commit into
cilium:mainfrom
immanuwell:ci/fix-images-dev-unquoted-sha

Conversation

@immanuwell

Copy link
Copy Markdown
Contributor

images-dev.yaml "Getting image tag" step runs this on push-to-main events:

if [ ${{ github.event.pull_request.head.sha }} != "" ]; then

github.event.pull_request.head.sha is empty on push events, so bash sees [ != "" ] and logs [: !=: unary operator expected on every merge to main. CI still passes (else branch runs fine), but the error shows up in every run.

Fix: quote the expression so bash sees [ "" != "" ] instead.

To reproduce: check the "Getting image tag" step in any Dev Image CI Build run triggered by a push to main.

Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru>
@tklauser tklauser merged commit f6a7022 into cilium:main Jun 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants