Skip to content
This repository was archived by the owner on Apr 10, 2026. It is now read-only.

Code/structure/compile fixes#185

Merged
hschoenburg merged 2 commits into
cosmos:masterfrom
quantaf1re:Fix_2
Jan 6, 2020
Merged

Code/structure/compile fixes#185
hschoenburg merged 2 commits into
cosmos:masterfrom
quantaf1re:Fix_2

Conversation

@quantaf1re

Copy link
Copy Markdown
Contributor

Changed:

Spelling

  • Mentioning that nothing is supposed to be cloned
  • Saying to create files instead of open them when they don't exist
  • Added the comma so this can compile:
    var app = &helloChainApp{
        appStarter,
    }
  • Corrected file path to x/greeter/client/cli/query.go in client.md

@quantaf1re quantaf1re changed the title Code/compile fixes Code/structure/compile fixes Nov 3, 2019
@quantaf1re quantaf1re mentioned this pull request Nov 3, 2019

@hschoenburg hschoenburg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good to me

@tac0turtle

Copy link
Copy Markdown
Contributor

Could you resolve the merge conflicts and then we can merge

@hschoenburg hschoenburg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my apologies for the confusing instructions .Thanks for your contribution

@hschoenburg hschoenburg self-assigned this Jan 3, 2020
@hschoenburg

Copy link
Copy Markdown
Contributor

@quantaf1re can you make sure to check the "Allow edits from maintainers" check box on your PR? Then I can reselve these conflicts and get you PR merged promptly. Thank you for the contribution.

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@quantaf1re

Copy link
Copy Markdown
Contributor Author

I just saw these comments sorry
Hmm, "Allow edits from maintainers" is already checked

@tac0turtle

Copy link
Copy Markdown
Contributor

@hschoenburg you can set his repo to a remote and pull the branch then push it yourself, I find this easiest

@hschoenburg hschoenburg merged commit 0804478 into cosmos:master Jan 6, 2020
@hschoenburg

Copy link
Copy Markdown
Contributor

Thanks @quantaf1re !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants