Fix missing models.dev date handling for created_at metadata#652
Merged
Conversation
crmne
approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 81.36% 81.37%
=======================================
Files 116 116
Lines 5425 5427 +2
Branches 1426 1427 +1
=======================================
+ Hits 4414 4416 +2
Misses 1011 1011 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes an edge case in
Models.models_dev_model_to_infowherecreated_atwas built from a blank date when bothrelease_dateandlast_updatedwere missing.Before this fix, it could build
" 00:00:00 UTC", which later parsed to the current date, causing incorrect and non-deterministiccreated_atvalues in model metadata.This PR:
created_atonly when a non-blank date is present.created_atasnilwhen both source dates are missing.Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes