Fix ActiveStorage::Blob re-upload if used in with: param#683
Merged
Conversation
crmne
approved these changes
Mar 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 81.63% 81.75% +0.12%
==========================================
Files 117 117
Lines 5522 5526 +4
Branches 1441 1444 +3
==========================================
+ Hits 4508 4518 +10
+ Misses 1014 1008 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes #665
When an
ActiveStorage::Blobis passed toaskorcreate_user_messageviawith:, it is downloaded and re-uploaded as a new blob. This is because the blob gets wrapped in aRubyLLM::Attachmentduring content building, so it goes to theelsebranch inprepare_for_active_storageandconvert_to_active_storage_formatis called, which always creates a new IO hash.=> Fix by updating
convert_to_active_storage_formatto detectActiveStorageobjects and return it directly so it can be reused.Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes